Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pod disruption budgets that got missed in a rebase #906

Merged
merged 1 commit into from
May 27, 2021
Merged

Add pod disruption budgets that got missed in a rebase #906

merged 1 commit into from
May 27, 2021

Conversation

krmichel
Copy link
Contributor

@krmichel krmichel commented May 26, 2021 •
edited
Loading

Is this a bug fix or adding new feature?
Bug fix. These files got missed during a rebase of PR #856

What is this PR about? / Why do we need it?
Files are missing from the customization manifests

What testing is done?
Ensured the file names match those in the kustomization.yaml

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @krmichel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 26, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 26, 2021
@krmichel
Copy link
Contributor Author

@AndyXiangLi @wongma7 in my last rebase of the helm chart clean up I somehow missed that these files got dropped. Can I get an ok to test and a quick review, please? It is a very small PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1996

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.125%
Totals Coverage Status
Change from base Build 1993: 0.0%
Covered Lines: 1990
Relevant Lines: 2515
💛 - Coveralls

@utk231 utk231 mentioned this pull request May 26, 2021
Closed
@wongma7
Copy link
Contributor

wongma7 commented May 27, 2021

/lgtm
/ok-to-test
/approve

thanks

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 93264f6 into kubernetes-sigs:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyXiangLi AndyXiangLi Awaiting requested review from AndyXiangLi

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krmichel @k8s-ci-robot @coveralls @wongma7